--- rat/client/parameter.html	2007/06/13 01:01:33	1.45
+++ rat/client/parameter.html	2016/08/05 17:39:45	1.64.2.3
@@ -1,9 +1,11 @@
-<html>
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN"
+    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <!--
 The LearningOnline Network with CAPA
 Parameter Input Window
 //
-// $Id: parameter.html,v 1.45 2007/06/13 01:01:33 albertel Exp $
+// $Id: parameter.html,v 1.64.2.3 2016/08/05 17:39:45 raeburn Exp $
 //
 // Copyright Michigan State University Board of Trustees
 //
@@ -29,10 +31,11 @@ Parameter Input Window
 //
 -->
 <head>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <title>LON-CAPA</title>
-</head>
 
-<script>
+<script type="text/javascript">
+// <![CDATA[
 
 var ptype='';
 var pvalue='';
@@ -40,6 +43,7 @@ var preturn='';
 var pcode='';
 var pscat='';
 var pmarker='';
+var pmodal='';
 var pname='';
 
 var defhour=0;
@@ -67,8 +71,26 @@ function selwrite(text) {
 }
 
 function choicestart() {
-  this.window.choices.document.clear();
-  choicewrite('<html><body bgcolor="#FFFFFF">');
+  this.window.choices.document.open();
+  choicewrite('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">');
+  choicewrite('<html xmlns="http://www.w3.org/1999/xhtml">');
+  choicewrite('<head>');
+  choicewrite('<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />');
+  choicewrite('<title>LON-CAPA</title>');
+  choicewrite('<style type="text/css">');
+  choicewrite('<!--');
+  choicewrite('body {');
+  choicewrite('font-family: Verdana,Arial,Helvetica,sans-serif;');
+  choicewrite('line-height:130%;');
+  choicewrite('font-size:0.83em;');
+  choicewrite('background: #FFFFFF;');
+  choicewrite('}');
+  choicewrite('table.LC_parmsel_table {font-size: 90%;}');
+  choicewrite('table.LC_parmsel_table tr td { padding: 5px; border: 1px solid #C8C8C8;}');
+  choicewrite('-->');
+  choicewrite('</style>');
+  choicewrite('</head>');
+  choicewrite('<body>');
 }
 
 function choiceend() {
@@ -81,15 +103,23 @@ function choicewrite(text) {
 }
 
 function tablestart(headtext) {
-  choicewrite('<table><tr bgcolor="#AAFFAA"><th colspan=3>'+
+  choicewrite('<table class="LC_parmsel_table"><tr bgcolor="#C5DB99"><th colspan="3">'+
               headtext+'</th></tr>');
 }
 
 function valline(text,id1,id2) {
-  choicewrite('<tr bgcolor="#AAFFAA"><td>'+text+
-              '</td><td><input type=text size=4 name=val'+
-              id1+'></td><td>incl:<input type=checkbox name=val'+
-              id2+'></td></tr>');
+  choicewrite('<tr><td>'+text+
+              '</td><td><input type="text" size="4" name="val'+
+              id1+'" /></td><td>incl:<input type="checkbox" name="val'+
+              id2+'" /></td></tr>');
+}
+
+function escapeHTML(text) {
+  text = text.replace(/&/g, '&amp;');
+  text = text.replace(/"/g, '&quot;');
+  text = text.replace(/</g, '&lt;');
+  text = text.replace(/>/g, '&gt;');
+  return text;
 }
 
 function datecalc() {
@@ -108,11 +138,11 @@ function datecalc() {
 function hour() {
    var thishour=cdate.getHours();
     var i; var j;
-    choicewrite('<select name=hours onChange="parent.datecalc();">');
+    choicewrite('<select name="hours" onchange="parent.datecalc();">');
     for (i=0;i<=23;i++) {
-        choicewrite('<option value='+i);
+        choicewrite('<option value="'+i+'"');
         if (i==thishour) {
-            choicewrite(' selected');
+            choicewrite(' selected="selected"');
         }
         choicewrite('>');
         if (i==12) { choicewrite('noon'); } else {
@@ -132,11 +162,11 @@ function hour() {
 function minute() {
    var thisminutes=cdate.getMinutes();
     var i;
-    choicewrite('<select name=minutes onChange="parent.datecalc();">');
+    choicewrite('<select name="minutes" onchange="parent.datecalc();">');
     for (i=0;i<=59;i++) {
-        choicewrite('<option value='+i);
+        choicewrite('<option value="'+i+'"');
         if (i==thisminutes) {
-            choicewrite(' selected');
+            choicewrite(' selected="selected"');
         }
         choicewrite('>'+i+'</option>');
     }
@@ -146,11 +176,11 @@ function minute() {
 function second() {
    var thisseconds=cdate.getSeconds();
     var i;
-    choicewrite('<select name=seconds onChange="parent.datecalc();">');
+    choicewrite('<select name="seconds" onchange="parent.datecalc();">');
     for (i=0;i<=59;i++) {
-        choicewrite('<option value='+i);
+        choicewrite('<option value="'+i+'"');
         if (i==thisseconds) {
-            choicewrite(' selected');
+            choicewrite(' selected="selected"');
         }
         choicewrite('>'+i+'</option>');
     }
@@ -161,11 +191,11 @@ function second() {
 function date() {
    var thisdate=cdate.getDate();
     var i;
-    choicewrite('<select name=date onChange="parent.datecalc();">');
+    choicewrite('<select name="date" onchange="parent.datecalc();">');
     for (i=1;i<=31;i++) {
-        choicewrite('<option value='+i);
+        choicewrite('<option value="'+i+'"');
         if (i==thisdate) {
-            choicewrite(' selected');
+            choicewrite(' selected="selected"');
         }
         choicewrite('>'+i+'</option>');
     }
@@ -182,11 +212,11 @@ function year() {
    if (thisyear>nowyear) { loweryear=nowyear-2; }
    if (thisyear<nowyear) { upperyear=nowyear+5; } 
     var i;
-    choicewrite('<select name=year onChange="parent.datecalc();">');
+    choicewrite('<select name="year" onchange="parent.datecalc();">');
     for (i=loweryear;i<=upperyear;i++) {
-        choicewrite('<option value='+i);
+        choicewrite('<option value="'+i+'"');
         if (i==thisyear) {
-            choicewrite(' selected');
+            choicewrite(' selected="selected"');
         }
         choicewrite('>'+i+'</option>');
     }
@@ -196,11 +226,11 @@ function year() {
 function month() {
     var thismonth=cdate.getMonth();
     var i;
-    choicewrite('<select name=month onChange="parent.datecalc();">');
+    choicewrite('<select name="month" onchange="parent.datecalc();">');
     for (i=0;i<=11;i++) {
-        choicewrite('<option value='+i);
+        choicewrite('<option value="'+i+'"');
         if (i==thismonth) {
-            choicewrite(' selected');
+            choicewrite(' selected="selected"');
         }
         choicewrite('>'+months[i]+'</option>');
     }
@@ -211,58 +241,66 @@ function month() {
 function intminute() {
    var thisminutes=cmins;
     var i;
-    choicewrite('<select name=minutes onChange="parent.intcalc();">');
+    var result = '';
+    result += '<select name="minutes" onchange="parent.intcalc();">';
     for (i=0;i<=59;i++) {
-        choicewrite('<option value='+i);
+        result += '<option value="'+i+'"';
         if (i==thisminutes) {
-            choicewrite(' selected');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
+    result += '</select>';
+    return result;
 } 
 
 function inthour() {
    var thishours=chours;
     var i;
-    choicewrite('<select name=hours onChange="parent.intcalc();">');
+    var result = '';
+    result += '<select name="hours" onchange="parent.intcalc();">';
     for (i=0;i<=23;i++) {
-        choicewrite('<option value='+i);
+        result += '<option value="'+i+'"';
         if (i==thishours) {
-            choicewrite(' selected');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
-} 
+    result += '</select>';
+    return result;
+}
 
 function intsecond() {
    var thisseconds=csecs;
     var i;
-    choicewrite('<select name=seconds onChange="parent.intcalc();">');
+    var result = '';
+    result += '<select name="seconds" onchange="parent.intcalc();">';
     for (i=0;i<=59;i++) {
-        choicewrite('<option value='+i);
+        result += '<option value="'+i+'"';
         if (i==thisseconds) {
-            choicewrite(' selected');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
-} 
+    result += '</select>';
+    return result;
+}
 
 
 function intday() {
    var thisdate=cdays;
     var i;
-    choicewrite('<select name=date onChange="parent.intcalc();">');
+    var result ='';
+    result += '<select name="date" onchange="parent.intcalc();">';
     for (i=0;i<=31;i++) {
-        choicewrite('<option value='+i);
+        result += '<option value="'+i+'"';
         if (i==thisdate) {
-            choicewrite(' selected');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
+    result += '</select>';
+    return result;
 }
 
 function intcalc() {
@@ -312,9 +350,7 @@ function radiostringeval(newval) {
 }
 
 function callradiostringeval(newval) {
-   return 'onChange="parent.radiostringeval(\''
-          +newval+'\')" onClick="parent.radiostringeval(\''
-          +newval+'\')"';
+    return 'onclick="parent.radiostringeval(\''+newval+'\')"';
 }
 
 function intervaldis() {
@@ -347,7 +383,7 @@ function colorfield(ir,ig,ib) {
 
 function draw() {
    choicestart();
-   choicewrite('<form name=sch');
+   choicewrite('<form name="sch"');
    if (ptype=='int') {
       choicewrite(' action="javascript:integereval();"');
    }
@@ -357,6 +393,9 @@ function draw() {
    if (ptype=='string') {
       choicewrite(' action="javascript:stringeval();"');
    }
+   if (ptype != 'int' && ptype != 'float' && ptype != 'string') {
+       choicewrite(' action=""');
+   }
    choicewrite('>');
    if (ptype=='tolerance') {
 // 0: pscat
@@ -440,21 +479,24 @@ function draw() {
       }
       if (pscat=='interval') {
          tablestart('Time interval');
-         choicewrite('<tr bgcolor="#AAFFAA"><td colspan=3>');
-         intervaldis();
-         choicewrite('</td></tr><tr bgcolor="#AAFFAA"><td>Time:'
-         +'</td><td colspan=2>');
-         intday();choicewrite('days ');
-         inthour();choicewrite('hours ');
-         intminute(); choicewrite('mins '); intsecond();
-         choicewrite('secs</td></tr></table>');         
+         choicewrite( [
+            '<tr><td colspan="3">'+intervaldis()+'</td></tr>',
+            '<tr><td>Time:</td><td colspan="2">',
+                '<span style="white-space:nowrap">'+intday()+' days </span>',
+                '<span style="white-space:nowrap">'+inthour()+' hours</span>',
+                '<span style="white-space:nowrap">'+intminute()+' mins</span>',
+                '<span style="white-space:nowrap">'+intsecond()+' secs</span>',
+            '</td></tr>',
+            '</table>',
+            '<br />',
+            ].join("\n"));
       } else { 
-         choicewrite('<tr bgcolor="#AAFFAA"><td colspan=3>'
+         choicewrite('<tr><td colspan="3">'
          +cdate.toString()+
-         '</td></tr><tr bgcolor="#AAFFAA"><td>Date:</td><td colspan=2>');
+         '</td></tr><tr><td>Date:</td><td colspan="2">');
          month();date();year();
-         choicewrite('</td></tr><tr bgcolor="#AAFFAA"><td>Time:'
-         +'</td><td colspan=2>');hour();choicewrite('h ');minute();
+         choicewrite('</td></tr><tr><td>Time:'
+         +'</td><td colspan="2">');hour();choicewrite('h ');minute();
          choicewrite('m ');second();
          choicewrite('s</td></tr></table>');
       }
@@ -471,12 +513,12 @@ function draw() {
       } else {
        if (pscat=='range') {
          tablestart('Integer range');      
-         choicewrite('<tr bgcolor="#AAFFAA"><td>Lower Value:'+
-              '</td><td colspan=2><input type=text size=4 name=val2'+
-              '></td></tr>');
-         choicewrite('<tr bgcolor="#AAFFAA"><td>Upper Value:'+
-              '</td><td colspan=2><input type=text size=4 name=val4'+
-              '></td></tr></table>');
+         choicewrite('<tr><td>Lower Value:'+
+              '</td><td colspan="2"><input type="text" size="4" name="val2'+
+              '" /></td></tr>');
+         choicewrite('<tr><td>Upper Value:'+
+              '</td><td colspan="2"><input type="text" size="4" name="val4'+
+              '" /></td></tr></table>');
          var range=new Array;
          if ((svalue!='') && (typeof(svalue)!="undefined")) {
             range=svalue.split(',');
@@ -499,10 +541,10 @@ function draw() {
         if (pscat=='any') {
            tablestart('Integer');
         }
-        choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
-        choicewrite('<input name=intval size=10 value="'+svalue+
-                    '" name=intval onChange="parent.integereval()">');
-        choicewrite('</td></table>');
+        choicewrite('<tr><td>Value:</td><td colspan="2">');
+        choicewrite('<input name="intval" size="10" value="'+escapeHTML(svalue)+
+                    '" onchange="parent.integereval()" />');
+        choicewrite('</td></tr></table>');
       }
      }
    }
@@ -521,10 +563,10 @@ function draw() {
         if (pscat=='any') {
            tablestart('Floating point number');
         }
-        choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
-        choicewrite('<input name=floatval size=10 value="'+svalue+
-                    '" name=floatval onChange="parent.floateval()">');
-        choicewrite('</td></table>');
+        choicewrite('<tr><td>Value:</td><td colspan="2">');
+        choicewrite('<input name="floatval" size="10" value="'+escapeHTML(svalue)+
+                    '" onchange="parent.floateval()" />');
+        choicewrite('</td></tr></table>');
       }
    }
 
@@ -532,114 +574,183 @@ function draw() {
         if ((pscat=='any') || (pscat=='') || (pscat=='default') ||  
             (typeof(pscat)=='undefined')) {
            tablestart('Text');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
-           choicewrite('<input name="stringval" size="20" value="'+svalue+
-                    '" type="text" onChange="parent.stringeval()">');
+           choicewrite('<tr><td>Value:</td><td colspan="2">');
+           choicewrite('<input name="stringval" size="20" value="'+escapeHTML(svalue)+
+                    '" type="text" onchange="parent.stringeval()" />');
         }
         if (pscat=='yesno') {
            tablestart('Yes/No');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
            choicewrite('<label><input name="stringval" value="yes"'+
                   ' type="radio" '+callradiostringeval('yes'));
-           if (svalue=='yes') { choicewrite(' checked'); }
-           choicewrite('> Yes</label><br />');
+           if (svalue=='yes') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes</label><br />');
            choicewrite('<label><input name="stringval" value="no"'+
                   ' type="radio" '+callradiostringeval('no'));
-           if (svalue=='no') { choicewrite(' checked'); }
-           choicewrite('> No</label><br />');
+           if (svalue=='no') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No</label><br />');
+        }
+        if (pscat=='problemstatus') {
+           tablestart('Problem Status');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
+           choicewrite('<label><input name="stringval" value="yes"'+
+                  ' type="radio" '+callradiostringeval('yes'));
+           if (svalue=='yes') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes</label><br />');
+           choicewrite('<label><input name="stringval" value="answer"'+
+                  ' type="radio" '+callradiostringeval('answer'));
+           if (svalue=='answer') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes, and show correct answer if they exceed the maximum number of tries.</label><br />');
+           choicewrite('<label><input name="stringval" value="no"'+
+                  ' type="radio" '+callradiostringeval('no'));
+           if (svalue=='no') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No, don\'t show correct/incorrect feedback.</label><br />');
+           choicewrite('<label><input name="stringval" value="no_feedback_ever"'+
+                  ' type="radio" '+callradiostringeval('no_feedback_ever'));
+           if (svalue=='no_feedback_ever') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No, show no feedback at all.</label><br />');
         }
         if (pscat=='examtype') {
            tablestart('Exam Type');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
            choicewrite('<label><input name="stringval" value="online"'+
                 ' type="radio" '+callradiostringeval('online'));
-           if (svalue=='online') { choicewrite(' checked'); }
-           choicewrite('> Online</label><br />');
+           if (svalue=='online') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Online</label><br />');
            choicewrite('<label><input name="stringval" value="checkout"'+
               ' type="radio" '+callradiostringeval('checkout'));
-           if (svalue=='checkout') { choicewrite(' checked'); }
-           choicewrite('> Check out</label><br />');
+           if (svalue=='checkout') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Check out</label><br />');
        }
         if (pscat=='questiontype') {
            tablestart('Question Type');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
            choicewrite('<label><input name="stringval" value="problem"'+
                ' type="radio" '+callradiostringeval('problem'));
-           if (svalue=='problem') { choicewrite(' checked'); }
-           choicewrite('> Standard Problem</label><br />');
+           if (svalue=='problem') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Standard Problem</label><br />');
 //	   choicewrite('<label><input name="stringval" value="quiz"'+
 //                ' type="radio" '+callradiostringeval('quiz'));
-//         if (svalue=='quiz') { choicewrite(' checked'); }
-//         choicewrite('> Quiz</label><br />');
+//         if (svalue=='quiz') { choicewrite(' checked="checked"'); }
+//         choicewrite(' /> Quiz</label><br />');
            choicewrite('<label><input name="stringval" value="practice"'+
                   ' type="radio" '+callradiostringeval('practice'));
-           if (svalue=='practice') { choicewrite(' checked'); }
-           choicewrite('> Practice</label><br />');
+           if (svalue=='practice') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Practice</label><br />');
            choicewrite('<label><input name="stringval" value="exam"'+
                   ' type="radio" '+callradiostringeval('exam'));
-           if (svalue=='exam') { choicewrite(' checked'); }
-           choicewrite('> Exam</label><br />');
+           if (svalue=='exam') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Exam</label><br />');
 //         choicewrite('<label><input name="stringval" value="assess"'+
 //              ' type="radio" '+callradiostringeval('assess'));
-//         if (svalue=='assess') { choicewrite(' checked'); }
-//         choicewrite('> Assessment</label><br />');
+//         if (svalue=='assess') { choicewrite(' checked="checked"'); }
+//         choicewrite(' /> Assessment</label><br />');
            choicewrite('<label><input name="stringval" value="survey"'+
                 ' type="radio" '+callradiostringeval('survey'));
-           if (svalue=='survey') { choicewrite(' checked'); }
-           choicewrite('> Survey</label><br />');
+           if (svalue=='survey') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Survey</label><br />');
 //         choicewrite('<label><input name="stringval" value="form"'+
 //                ' type="radio" '+callradiostringeval('form'));
-//         if (svalue=='form') { choicewrite(' checked'); }
+//         if (svalue=='form') { choicewrite(' checked="checked"'); }
 //         choicewrite('> Input Form</label><br />');
+           choicewrite('<label><input name="stringval" value="surveycred"'+
+                ' type="radio" '+callradiostringeval('surveycred'));
+           if (svalue=='surveycred') { choicewrite(' checked="checked"'); }
+           choicewrite('> Survey (credit for submission)</label><br />');
+           choicewrite('<label><input name="stringval" value="anonsurvey"'+
+                ' type="radio" '+callradiostringeval('anonsurvey'));
+           if (svalue=='anonsurvey') { choicewrite(' checked="checked"'); }
+           choicewrite('> Anonymous Survey</label><br />');
+           choicewrite('<label><input name="stringval" value="anonsurveycred"'+
+                ' type="radio" '+callradiostringeval('anonsurveycred'));
+           if (svalue=='anonsurveycred') { choicewrite(' checked="checked"'); }
+           choicewrite('> Anonymous Survey (credit for submission)</label><br />');
+           choicewrite('<label><input name="stringval" value="randomizetry"'+
+                ' type="radio" '+callradiostringeval('randomizetry'));
+           if (svalue=='randomizetry') { choicewrite(' checked="checked"'); }
+           choicewrite('> New Randomization Each N Tries (default N=1)</label><br />');
            choicewrite('<label><input name="stringval" value="library"'+
                ' type="radio" '+callradiostringeval('library'));
-           if (svalue=='library') { choicewrite(' checked'); }
-           choicewrite('> Library</label><br />');
+           if (svalue=='library') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Library</label><br />');
+        }
+        if (pscat=='lenient') {
+           tablestart('Lenient Grading (Partial Credit)');
+           choicewrite('<tr><td>Value:</td><td colspan="2">');
+           choicewrite('<label><input name="stringval" value="yes"'+
+                  ' type="radio" '+callradiostringeval('yes'));
+           if (svalue=='yes') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes</label><br />');
+           choicewrite('<label><input name="stringval" value="no"'+
+                  ' type="radio" '+callradiostringeval('no'));
+           if (svalue=='no') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No</label><br />');
+           choicewrite('<label><input name="stringval" value="default"'+
+               ' type="radio" '+callradiostringeval('default'));
+           if (svalue=='default') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Default (only bubblesheet grading is lenient)</label><br />');
+        }
+        if (pscat=='discussvote') {
+           tablestart('Discussion Voting');
+           choicewrite('<tr><td>Value:</td><td colspan="2">');
+           choicewrite('<label><input name="stringval" value="yes"'+
+                  ' type="radio" '+callradiostringeval('yes'));
+           if (svalue=='yes') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes</label><br />');
+           choicewrite('<label><input name="stringval" value="notended"'+
+                  ' type="radio" '+callradiostringeval('notended'));
+           if (svalue=='notended') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes, unless discussion ended</label><br />');
+           choicewrite('<label><input name="stringval" value="no"'+
+                  ' type="radio" '+callradiostringeval('no'));
+           if (svalue=='no') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No</label><br />');
         }
         if (pscat=='ip') {
            tablestart('IP Number/Name');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
-           choicewrite('<input name="stringval" size="20" value="'+svalue+
-                    '" onChange="parent.stringeval()">');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
+           choicewrite('<input name="stringval" size="20" value="'+escapeHTML(svalue)+
+                    '" onchange="parent.stringeval()" />');
         }
         if (pscat=='fileext') {
             tablestart('Allowed File Extensions');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
            choicewrite('<label><input name="radstringval" value="txt"'+
                ' type="radio" '+callradiostringeval('txt'));
-           if (svalue=='txt') { choicewrite(' checked'); }
-           choicewrite('> Plain Text</label><br />');
+           if (svalue=='txt') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Plain Text</label><br />');
            choicewrite('<label><input name="radstringval" value="png,jpg,jpeg,gif"'+
                ' type="radio" '+callradiostringeval('png,jpg,jpeg,gif'));
-           if (svalue=='png,jpg,jpeg,gif') { choicewrite(' checked'); }
-           choicewrite('> Picture File</label><br />');
-           choicewrite('<label><input name="radstringval" value="doc,xls,ppt"'+
-               ' type="radio" '+callradiostringeval('doc,xls,ppt'));
-           if (svalue=='doc,xls,ppt') { choicewrite(' checked'); }
-           choicewrite('> Office Document</label><br />');
-           choicewrite('<input name="stringval" size="20" value="'+svalue+
-                    '" onChange="parent.stringeval()">');
+           if (svalue=='png,jpg,jpeg,gif') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Picture File</label><br />');
+           choicewrite('<label><input name="radstringval" value="doc,docx,xls,xlsx,ppt,pptx"'+
+               ' type="radio" '+callradiostringeval('doc,docx,xls,xlsx,ppt,pptx'));
+           if (svalue=='doc,docx,xls,xlsx,ppt,pptx') { choicewrite(' checked="checked"'); }
+           if (svalue=='doc,xls,ppt') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Office Document</label><br />');
+           choicewrite('<input name="stringval" size="20" value="'+escapeHTML(svalue)+
+                    '" onchange="parent.stringeval()" />');
        }
        if (pscat=='useslots') {
            tablestart('Slots control access');
-	   choicewrite('<tr bgcolor="#AAFFAA"><td>Value:</td><td colspan=2>');
+	   choicewrite('<tr><td>Value:</td><td colspan="2">');
            choicewrite('<label><input name="stringval" value="no"'+
                   ' type="radio" '+callradiostringeval('no'));
-           if (svalue=='no') { choicewrite(' checked'); }
-           choicewrite('> No</label><br />');
+           if (svalue=='no') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No</label><br />');
            choicewrite('<label><input name="stringval" value="resource"'+
                   ' type="radio" '+callradiostringeval('resource'));
-           if (svalue=='resource') { choicewrite(' checked'); }
-           choicewrite('> Yes, and the scope of student selected slot is a single resource.</label><br />');
+           if (svalue=='resource') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes, and the scope of student selected slot is a single resource.</label><br />');
            choicewrite('<label><input name="stringval" value="map"'+
                   ' type="radio" '+callradiostringeval('map'));
-           if (svalue=='map') { choicewrite(' checked'); }
-           choicewrite('> Yes, and the scope of student selected slot is the enclosing map/folder. When checking in, it applies to only one resource.</label><br />');
+           if (svalue=='map') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes, and the scope of student selected slot is the enclosing map/folder. When checking in, it applies to only one resource.</label><br />');
            choicewrite('<label><input name="stringval" value="map_map"'+
                   ' type="radio" '+callradiostringeval('map_map'));
-           if (svalue=='map_map') { choicewrite(' checked'); }
-           choicewrite('> Yes, and the scope of student selected slot is the enclosing map/folder. When checking in, all resources in the map/folder are checked in..</label><br />');
-        choicewrite('</td></table>');
+           if (svalue=='map_map') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes, and the scope of student selected slot is the enclosing map/folder. When checking in, all resources in the map/folder are checked in.</label><br />');
+        choicewrite('</td></tr></table>');
       }
    }
    
@@ -648,7 +759,7 @@ function draw() {
       choicewrite('<table>');
       if (svalue) {
          choicewrite('<tr><td colspan="9">Current choice:</td><td bgcolor="'+
-                     svalue+'" colspan="2">&nbsp;</td></tr>');
+                     escapeHTML(svalue)+'" colspan="2">&nbsp;</td></tr>');
       }
       for (var ir=0; ir<=10; ir++) {
           for (var ig=0; ig<=10; ig++) {
@@ -669,7 +780,7 @@ function draw() {
 function sopt(va,text) {
    selwrite('<option value="'+va+'"');
    if (va==pscat) {
-     selwrite(' selected');
+     selwrite(' selected="selected"');
    }
    selwrite('>'+text+'</option>');
 }
@@ -751,6 +862,7 @@ function init() {
      if (pair[0]=='call') { pcode=pair[1]; }
      if (pair[0]=='marker') { pmarker=pair[1]; }
      if (pair[0]=='name') { pname=pair[1]; }
+     if (pair[0]=='modal') { pmodal=pair[1]; }
      if (pair[0]=='defhour' && pair[1] >= 0 && pair[1] < 24 ) {
          defhour=pair[1];
      }
@@ -778,11 +890,26 @@ function init() {
      }
   }
 
-  this.window.selector.document.clear();
-  selwrite('<html><body bgcolor="#FFFFFF">');
-
-  selwrite('<form name="fsel"><b>'+pname+'</b><br>');
-  selwrite('<select name="fcat" onChange="parent.catchange();">');
+  this.window.selector.document.open();
+  selwrite('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">');
+  selwrite('<html xmlns="http://www.w3.org/1999/xhtml">');
+  selwrite('<head>');
+  selwrite('<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />');
+  selwrite('<title>LON-CAPA</title>');
+  selwrite('<style type="text/css">');
+  selwrite('<!--');
+  selwrite('body {');
+  selwrite('font-family: Verdana,Arial,Helvetica,sans-serif;');
+  selwrite('line-height:130%;');
+  selwrite('font-size:0.83em;');
+  selwrite('background: #FFFFFF;');
+  selwrite('}');
+  selwrite('-->');
+  selwrite('</style>');
+  selwrite('</head>');
+  selwrite('<body>');
+  selwrite('<form name="fsel" action=""><b>'+pname+'</b><br />');
+  selwrite('Format of Value(s): <select name="fcat" onchange="parent.catchange();">');
 
   if (ptype=='tolerance') {
      sopt('default','Default');
@@ -793,11 +920,14 @@ function init() {
   }
 
   if (ptype=='date') {
-     sopt('default','Default');
-     sopt('start','Starting Date');
-     sopt('end','Ending Date');
-     sopt('interval','Time Interval');
-     
+     if (pscat != 'interval') {
+         sopt('default','Default');
+	 sopt('start','Starting Date');
+	 sopt('end','Ending Date');
+     } else {
+         sopt('interval','Time Interval');
+     }
+
      if ((pvalue!='') && (typeof(pvalue)!="undefined")) {
         cdate.setTime(pvalue*1000);
      } else {        
@@ -840,8 +970,11 @@ function init() {
   if (ptype=='string') {
      //sopt('default','Default');
      if (pscat == 'yesno')        { sopt('yesno','Yes/No'); }
+     else if (pscat == 'problemstatus'){ sopt('problemstatus','Problem Status'); }
      else if (pscat == 'examtype')     { sopt('examtype','Exam Type'); }
      else if (pscat == 'questiontype') { sopt('questiontype','Question Type'); }
+     else if (pscat == 'lenient')      { sopt('lenient','Lenient Grading (Partial Credit)'); }
+     else if (pscat == 'discussvote')  { sopt('discussvote','Discussion Voting'); }
      else if (pscat == 'ip')           { sopt('ip','IP Number/Name'); }
      else if (pscat == 'fileext')      { sopt('fileext','File Extension'); }
      else if (pscat == 'useslots')     { sopt('useslots','Slots control access'); }
@@ -855,67 +988,47 @@ function init() {
   }
 
   selwrite('</select></form>');
-
+  var targ='parent.opener';
+  if (pmodal==1) {
+     targ='parent.parent';
+  }  
   selwrite('<a href="javascript:parent.assemble();');
   if (preturn!='') {
-     selwrite(
-      'parent.opener.document.'+preturn+'_value.value=parent.window.svalue;');
-     selwrite(
-      'parent.opener.document.'+preturn+'_type.value=parent.window.stype;');
+     selwrite(targ+'.document.'+preturn+'_value.value=parent.window.svalue;');
+     selwrite(targ+'.document.'+preturn+'_type.value=parent.window.stype;');
   }
   if (pmarker!='') {
-     selwrite(
-     'parent.opener.document.'+preturn+'_marker.value=parent.window.pmarker;');
+     selwrite(targ+'.document.'+preturn+'_marker.value=parent.window.pmarker;');
   }
   if (pcode!='') {
-     selwrite('parent.opener.'+pcode+'();');
+     selwrite(targ+'.'+pcode+'();');
   }
   selwrite('">Save</a>&nbsp;&nbsp;');
 
   selwrite('<a href="javascript:');
-     selwrite(
-      'parent.opener.document.'+preturn+'_value.value='+"'';");
+  selwrite(targ+'.document.'+preturn+'_value.value='+"'';");
   if (pmarker!='') {
      selwrite(
-     'parent.opener.document.'+preturn+'_marker.value=parent.window.pmarker;');
+     targ+'.document.'+preturn+'_marker.value=parent.window.pmarker;');
   }
   if (pcode!='') {
-     selwrite('parent.opener.'+pcode+'();');
+     selwrite(targ+'.'+pcode+'();');
   }
   selwrite('">Delete</a>&nbsp;&nbsp;');
  
-  selwrite('<a href="javascript:');
-// Old code :
-//----------------------------------------------------------------------
-//  if (preturn!='') {
-//     selwrite('parent.opener.document.'+preturn+'_value.value='+"'';");
-//     selwrite('parent.opener.document.'+preturn+'_type.value='+"'';");
-// }
-//  if (pmarker!='') {
-//     selwrite('parent.opener.document.'+preturn+'_marker.value='+"'';");
-//  }
-//  if (pcode!='') {
-//     selwrite('parent.opener.'+pcode+'();');
-//  }
-//----------------------------------------------------------------------
-// Just close the window to 'cancel' the operation.  There are javascript
-// errors in the above commented out code that I have not been able to 
-// track down.  I think they reside in 'parent.opener.'+pcode+'();'
-//
-  selwrite('this.parent.close();');
-  selwrite('">Cancel</a>'); 
- 
   selwrite('</body></html>');
   this.window.selector.document.close();
   draw();
   
 }
 
+// ]]>
 </script>
+</head>
 
-<frameset rows="120,*" onLoad="init();">
-<frame name=selector src="empty.html">
-<frame name=choices src="empty.html">
+<frameset rows="120,*" onload="init();">
+<frame name="selector" src="empty.html" />
+<frame name="choices" src="empty.html" />
 </frameset>
 
 
