--- capa/capa51/pProj/capaCommon.c	2000/06/27 18:28:48	1.11
+++ capa/capa51/pProj/capaCommon.c	2000/11/02 20:20:04	1.18
@@ -1,6 +1,29 @@
+/* Library of useful functions
+   Copyright (C) 1992-2000 Michigan State University
+
+   The CAPA system is free software; you can redistribute it and/or
+   modify it under the terms of the GNU General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The CAPA system is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+
+   You should have received a copy of the GNU General Public
+   License along with the CAPA system; see the file COPYING.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.
+
+   As a special exception, you have permission to link this program
+   with the TtH/TtM library and distribute executables, as long as you
+   follow the requirements of the GNU GPL in regard to all of the
+   software in the executable aside from TtH/TtM.
+*/
+
 /* =||>|===================== capaCommon.c =====================|<||= */
 /* created 1994 by Isaac Tsai                                         */
-/* 1994, 1995, 1996, 1997, 1998, 1999  copyrighted by Isaac Tsai      */
 /* TODO: restructure capa_check_ans*() calls into one                 */
 /* =||>|===================== capaCommon.c =====================|<||= */
 #include <ctype.h>
@@ -25,6 +48,8 @@ int     yyparse();
 extern  FILE *yyin;
 extern  void yyrestart();
 
+extern  FILE *dfp;
+
 /*----------------------------------------------------------*/
 /*  RETURN: -1 file error                                   */
 /*           0 success                                      */
@@ -2994,10 +3019,10 @@ capa_check_ans(ai,ans, error) AnswerInfo
               for(idx=0;idx<ANSWER_STRING_LENG;idx++) choice[idx] = 0;
               result = EXACT_ANS;
               for(ii=0;ii<corr_len; ii++) {
-                idx = toupper(correct[ii]) - 'A'; choice[idx] =  1;
+                idx = toupper(s[ii]) - 'A'; choice[idx] =  1;
               }
               for(ii=0;ii<input_len;ii++) {
-                idx = toupper(answer[ii]) - 'A';
+                idx = toupper(ans[ii]) - 'A';
                 if(choice[idx] != 1 )  result = INCORRECT;
               }
             } else { result = INCORRECT; }
@@ -3177,6 +3202,10 @@ capa_check_answer(p, answer, error) Prob
          /* and the result will be given back as 0 or 1 to indicate the */
          /* given answer is correct or not */
          /* arguments are given to the program as */
+         /* before running the program, check its existance first */
+         /* should we specify a time out period in capa.config file? */
+         /* set up a timer for this purpose */
+         /* FILE *popen (const char *command,const char *type ); */
 
           break;
     
@@ -3184,7 +3213,7 @@ capa_check_answer(p, answer, error) Prob
   return (result);
 }
 
-/* ----------------------------------------------------------------------------------- */
+/* -------------------------------------------------------------------------- */
 /*   assumming the formula is *fml_str and the student input is *input_str             */
 /*   according to the type of tolerance, we form the final formula as                  */
 /*      absolute tolerance:  (*fml_str) - (*input_str)                                 */
@@ -3344,8 +3373,15 @@ Problem_t *p; char **answers; int cnt; c
     outcomes = (int *)capa_malloc(sizeof(int),cnt);
     for(ii=0;ii<cnt;ii++) outcomes[ii]=0;  /* initialize the outcomes array */
     outcomes[0] = capa_check_answer(p, answers[0], &errormsg[0]);
+#ifdef    COMMON_DBUG
+    printf("CAPA_CHECK_ANSWER(%s,%s):: outcome[0]=%d\n", 
+       p->answer,answers[0],outcomes[0]); 
+#endif
     for(ii=1, ai = p->ans_list; ai; ii++,ai = ai->ans_next  ) {
        outcomes[ii] =  capa_check_ans(ai,answers[ii],&(errormsg[ii]));
+#ifdef    COMMON_DBUG
+    printf("CAPA_CHECK_ANS(%s,%s): outcome[%d]=%d\n", ai->ans_str,answers[ii],ii,outcomes[ii]); 
+#endif
     }
     done = ii = 0;
     result = 0;
@@ -3360,10 +3396,12 @@ Problem_t *p; char **answers; int cnt; c
       ii++;
       if(ii==cnt) done = 1;
     }
-    if( result == 0 ) { /* check if any of the outcome has failed to be a numeric */
+    if( result == 0 ) { 
+    /* check if any of the outcome has failed to be a numeric 
+       or was a malformed equation */
       done = ii = 0;
       while( !done ) {
-        if( outcomes[ii] == WANTED_NUMERIC ) {
+        if( outcomes[ii] == WANTED_NUMERIC || outcomes[ii] == BAD_FORMULA ) {
           result = outcomes[ii];
           done = 1;
         }
@@ -3371,7 +3409,7 @@ Problem_t *p; char **answers; int cnt; c
         if(ii==cnt) done = 1;
       }
     }
-    if( result == 0 ) { /* check if any of the outcome has failed on sig figs */
+    if( result == 0 ) {/*check if any of the outcome has failed on sig figs*/
       done = ii = 0;
       while( !done ) {
         if( outcomes[ii] == SIG_FAIL ) {
@@ -3514,7 +3552,7 @@ char *key_word;char *value;
 	  }
 	}
 	if (c=='\n') found=1;
-	if (((char)c)==((char)EOF)) break;
+	if (((char)c)==((char)EOF)) {failed=1;break;}
       }
     }
   } while (!done && !failed);